feat: add Vietnamese translation support for exercise instructions#18
Open
vucongchien wants to merge 1 commit into
Open
feat: add Vietnamese translation support for exercise instructions#18vucongchien wants to merge 1 commit into
vucongchien wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request adds full Vietnamese (VI) translation support for all 1,324 exercises in the dataset. It updates the raw JSON database, the interactive browser interface (
index.html), the developer setup wizard (setup.html), and the project documentation (README.md).Translation Methodology & Quality Assurance
Unlike standard machine translations, which often fail to parse fitness-specific jargon correctly (e.g., mistranslating terms like curl, press, row, lats, or calves), every single one of the 1,324 exercises has been manually reviewed and cross-checked line-by-line to ensure accurate Vietnamese fitness terminology. We have carefully verified that:
We hope this contribution makes this great resource even more useful for the Vietnamese developer and fitness community!
Detailed Changes
1. Dataset Update
data/exercises.json:instructions.vi(full text instructions in Vietnamese) andinstruction_steps.vi(step-by-step array of Vietnamese strings) to all 1,324 exercise records.2. Interactive Browser (
index.html)EXERCISESdataset to incorporate the Vietnamese translations.instructions_vicolumn.3. Developer Setup Wizard (
setup.html)instructions_vicolumns (asTEXT/NVARCHAR) to all table creation templates (CREATE TABLEfor MSSQL, PostgreSQL, MySQL, and SQLite).INSERT INTOqueries.4. Documentation (
README.md)instructions.vi.Verification and Testing
We ran an automated integrity script to validate the updated dataset:
instruction_steps.vimatchesinstruction_steps.enexactly for every exercise.1324/1324 exercises verified. 0 errors, 0 step mismatches.Gnu/Linux and Windows browser testing has also been performed on
index.htmlandsetup.htmlto confirm that tab-switching and SQL generation work perfectly.