fix: Hedera Transaction Builder typing improvements#417
fix: Hedera Transaction Builder typing improvements#417kalpana-15 wants to merge 3 commits intohashgraph:mainfrom
Conversation
338e159 to
5015b1c
Compare
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
|
Hi @kalpana-15, I’ve pushed your code to a branch in our repo and made some additional changes and fixes - your original code had a few TypeScript errors. Please see the PR: #502 Thank you for your contribution, and apologies for the delayed response! |
|
Hello @kalpana-15, Also, we recommend using Conventional Commits approach for the commit messages. |
|
Hi @kalpana-15 - we’d like to merge this commit. If the GPG signing issue isn’t resolved soon, we may need to squash the commit. In that case, the contribution won’t appear under your authorship, but we will make sure to credit you in the next release commit message. |
|
@skurzyp-blockydevs lets just merge it |
Description:
This PR documents and clarifies the correct usage of Hedera builder methods after refactoring them to remove unsafe any casts. It explains why SDK constructors should not receive unsupported parameters and how builder methods now construct transactions explicitly using SDK APIs. This helps contributors understand the design decisions and prevents reintroducing unsafe patterns in the future.
Changes included:
Related issue(s):
Fixes the issue related to unsafe any usage in HederaBuilder transaction construction
issue #370
Notes for reviewer:
This PR does not change functionality. It documents and reinforces the refactored, type-safe builder approach already implemented.
Checklist: