feat: add HOL audit trail hcs-2 + hcs-1#576
Conversation
1978b53 to
b4fb0f5
Compare
skurzyp-blockydevs
left a comment
There was a problem hiding this comment.
The logic here looks solid to me. I'm just not sure aboute the current directory structure. src/shared is starting to feel a bit bloated, and we might want to rethink how we organize these hooks, policies, and their underlying services.
Given the size and scope of this hook - and the fact that it's tied specifically to HOL standards rather than core Hedera functionality - I think it me might consider extracting it into its own companion package (e.g., hedera-agent-kit-hol-extension or @hedera-agent-kit/hol). Separating this out would keep the core SDK lightweight and make the HOL-specific tools easier to maintain.
25396ac to
bbd5768
Compare
|
I moved hook and related directories to own directory. Please review @skurzyp-blockydevs @piotrswierzy. |
c11791a to
cb065bf
Compare
|
@kierzniak Could you please add some integration tests? The idea is to test on chain execution and validate it without using llm so those tests should look similar to the
Mind that the setup/teardown approach of this kind of tests. We need to ensure that hbars transfered to the accounts created during those tests are sent back and not leaking. Also, mind that we can check the onchain data using Mirror node but it has some delay 4-5s typically so artificial sleeps are needed. |
6e95d25 to
d7f06fe
Compare
Signed-off-by: Piotr Kierzniewski <piotr.kierzniewski@blockydevs.com>
d7f06fe to
0e5d56a
Compare
@skurzyp-blockydevs Integrations test added. Please review. |
skurzyp-blockydevs
left a comment
There was a problem hiding this comment.
Approved but we will need to document it later
Signed-off-by: Piotr Kierzniewski <piotr.kierzniewski@blockydevs.com>
Fix #562