Skip to content

feat: add HOL audit trail hcs-2 + hcs-1#576

Merged
kierzniak merged 1 commit intofeat/poc-policiesfrom
feat/add-hol-audit-trail-562
Mar 18, 2026
Merged

feat: add HOL audit trail hcs-2 + hcs-1#576
kierzniak merged 1 commit intofeat/poc-policiesfrom
feat/add-hol-audit-trail-562

Conversation

@kierzniak
Copy link

Fix #562

@kierzniak kierzniak requested review from a team as code owners March 12, 2026 10:16
@kierzniak kierzniak force-pushed the feat/add-hol-audit-trail-562 branch 2 times, most recently from 1978b53 to b4fb0f5 Compare March 12, 2026 10:41
Copy link
Contributor

@skurzyp-blockydevs skurzyp-blockydevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here looks solid to me. I'm just not sure aboute the current directory structure. src/shared is starting to feel a bit bloated, and we might want to rethink how we organize these hooks, policies, and their underlying services.

Given the size and scope of this hook - and the fact that it's tied specifically to HOL standards rather than core Hedera functionality - I think it me might consider extracting it into its own companion package (e.g., hedera-agent-kit-hol-extension or @hedera-agent-kit/hol). Separating this out would keep the core SDK lightweight and make the HOL-specific tools easier to maintain.

@kierzniak kierzniak force-pushed the feat/add-hol-audit-trail-562 branch 3 times, most recently from 25396ac to bbd5768 Compare March 12, 2026 12:23
@kierzniak
Copy link
Author

I moved hook and related directories to own directory. Please review @skurzyp-blockydevs @piotrswierzy.

@kierzniak kierzniak force-pushed the feat/add-hol-audit-trail-562 branch 2 times, most recently from c11791a to cb065bf Compare March 12, 2026 13:16
@skurzyp-blockydevs
Copy link
Contributor

@kierzniak Could you please add some integration tests? The idea is to test on chain execution and validate it without using llm so those tests should look similar to the test/inegration/hedera. The idea is to:

  • create hak agent with this hook configured for some selected tool
  • manually triger that tool - we want to skip the LLM inference
  • check onchain result of the hook

Mind that the setup/teardown approach of this kind of tests. We need to ensure that hbars transfered to the accounts created during those tests are sent back and not leaking. Also, mind that we can check the onchain data using Mirror node but it has some delay 4-5s typically so artificial sleeps are needed.

@kierzniak kierzniak force-pushed the feat/add-hol-audit-trail-562 branch 2 times, most recently from 6e95d25 to d7f06fe Compare March 18, 2026 07:26
Signed-off-by: Piotr Kierzniewski <piotr.kierzniewski@blockydevs.com>
@kierzniak kierzniak force-pushed the feat/add-hol-audit-trail-562 branch from d7f06fe to 0e5d56a Compare March 18, 2026 09:04
@kierzniak
Copy link
Author

@kierzniak Could you please add some integration tests? The idea is to test on chain execution and validate it without using llm so those tests should look similar to the test/inegration/hedera. The idea is to:

  • create hak agent with this hook configured for some selected tool
  • manually triger that tool - we want to skip the LLM inference
  • check onchain result of the hook

Mind that the setup/teardown approach of this kind of tests. We need to ensure that hbars transfered to the accounts created during those tests are sent back and not leaking. Also, mind that we can check the onchain data using Mirror node but it has some delay 4-5s typically so artificial sleeps are needed.

@skurzyp-blockydevs Integrations test added. Please review.

Copy link
Contributor

@skurzyp-blockydevs skurzyp-blockydevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but we will need to document it later

@kierzniak kierzniak merged commit ec3a816 into feat/poc-policies Mar 18, 2026
10 checks passed
@kierzniak kierzniak deleted the feat/add-hol-audit-trail-562 branch March 18, 2026 09:26
kierzniak added a commit that referenced this pull request Mar 18, 2026
Signed-off-by: Piotr Kierzniewski <piotr.kierzniewski@blockydevs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants