Draft
Conversation
- Added standard policies like `MaxHbarTransferPolicy`, `TokenAllowlistPolicy`, and `RequiredMemoPolicy`. - Integrated policy checks in `CREATE_ACCOUNT_TOOL` and `TRANSFER_HBAR_TOOL`. - Added example configuration and setup for policies in the new `policy-example` directory. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…policies in relevant tools - Introduced two new policies: `ImmutabilityPolicy` to block modifications/deletions of specific accounts and tokens, and `NoInfiniteSupplyPolicy` to prevent creating tokens with infinite supply. - Integrated policy enforcement into `UPDATE_ACCOUNT_TOOL`, `DELETE_ACCOUNT_TOOL`, `CREATE_FUNGIBLE_TOKEN_TOOL`, `CREATE_NON_FUNGIBLE_TOKEN_TOOL`, and `UPDATE_TOKEN_TOOL`. - Updated documentation with descriptions of the new policies and their applicable tools. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
- Replaced manual runtime checks for `accountId` and `tokenId` with Zod schemas. - Simplified and improved type safety for `shouldBlock` logic. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
- Removed tools: `burn_token_tool`, `wipe_token_tool`, `pause_token_tool`, `unpause_token_tool`, `freeze_token_tool`, `unfreeze_token_tool`, `grant_token_kyc_tool`, and `revoke_token_kyc_tool`. - Improved clarity and maintainability of the allowlist. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…ooks Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
# Conflicts: # typescript/src/plugins/core-account-plugin/tools/account/transfer-hbar.ts # typescript/src/shared/configuration.ts # typescript/src/shared/policy.ts
…affectedPoints` to policies - Simplified tools by removing inline policy checks. - Introduced the `affectedPoints` attribute in policies to standardize enforcement integration. - Adjusted relevant policy implementations to utilize `ToolExecutionPoint.PostParamsNormalization`. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
- Added FIXME comments to indicate policies referencing tools that currently lack policy support. - Commented out unused tools in policy definitions for clarity. - Adjusted `policy-example` to reflect limitations in functional policies. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…s` and enhance hook implementations - Added `PolicyValidationParams` for consistent parameter handling across policies. - Refactored `ToolExecutionPoint` to improve clarity and add support for `PostCoreAction` and `PostSecondaryAction`. - Updated all policies to use `validationParams`, providing access to context-specific data like raw and normalized parameters. - Renamed `action` to `coreAction` and `submit` to `secondaryAction` in tools to improve semantic clarity. - Adjusted tool execution flow to incorporate new hooks and parameter structure. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…s` and enhance hook implementations - Added `PolicyValidationParams` for consistent parameter handling across policies. - Refactored `ToolExecutionPoint` to improve clarity and add support for `PostCoreAction` and `PostSecondaryAction`. - Updated all policies to use `validationParams`, providing access to context-specific data like raw and normalized parameters. - Renamed `action` to `coreAction` and `submit` to `secondaryAction` in tools to improve semantic clarity. - Adjusted tool execution flow to incorporate new hooks and parameter structure. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…in `TRANSFER_HBAR_TOOL` Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…ce policy hook support Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…management Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…ent approach Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…licies - Added comprehensive unit test coverage for the following policies: - `RequiredMemoPolicy` - `TokenAllowlistPolicy` - `NoInfiniteSupplyPolicy` - `ImmutabilityPolicy` - `MaxHbarTransferPolicy` - Enhanced policy validation logic to ensure edge case handling. - Updated `policy-hooks` test to include additional hook coverage. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
# Conflicts: # docs/DEVEXAMPLES.md # typescript/examples/langchain-v1/package-lock.json
… all tools Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
- Introduced `HcsAuditTrailHook` to log tool execution on Hedera Consensus Service (HCS) topics. - Added E2E, integration, and unit tests to verify functionality and ensure robust behavior. - Updated shared exports and relevant interface methods to support the new hook. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…railHook Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
# Conflicts: # typescript/src/shared/index.ts
…error handling - Added `HookExecInterruptError` to enable propagation of critical errors across hooks. - Updated `HcsAuditTrailHook` to throw `HookExecInterruptError` in unsupported agent modes. - Refactored unit and integration tests to validate error propagation behavior. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…Type which is failing with ADK, move logic to parameters normalizer Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
…dling - Added clear instructions for using the native ADK CLI (`npx adk run agent.ts`) and web tools. - Updated Hedera client initialization to support DER and ED25519 private keys. - Refined `plugin-tool-calling-agent.ts` with better session handling, improved logging, and clearer user prompts. - Updated documentation to recommend native ADK tools for interaction. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
# Conflicts: # docs/DEVEXAMPLES.md # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/approve-non-fungible-token-allowance.ts # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/transfer-non-fungible-token-with-allowance.ts # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/transfer-non-fungible-token.ts
- Added new account response fields (`memo`, `createdTimestamp`, `ethereumNonce`, `maxAutomaticTokenAssociations`, and `deleted`). - Updated HCS audit logging to include recursive stringification of complex parameters. - Enhanced test coverage for nested parameter handling and improved SDK-specific object logging. Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: Piotr Kierzniewski <piotr.kierzniewski@blockydevs.com> Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com> Co-authored-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
# Conflicts: # docs/DEVEXAMPLES.md # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/approve-non-fungible-token-allowance.ts # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/transfer-non-fungible-token-with-allowance.ts # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/transfer-non-fungible-token.ts
# Conflicts: # docs/DEVEXAMPLES.md # typescript/examples/adk/tsconfig.json # typescript/src/plugins/core-token-plugin/tools/non-fungible-token/approve-non-fungible-token-allowance.ts # typescript/src/shared/index.ts # typescript/src/shared/policy.ts # typescript/src/shared/tools.ts # typescript/test/e2e/hooks/hcs-audit-trail-hook.e2e.test.ts # typescript/test/integration/hooks/hcs-audit-trail-hook.integration.test.ts # typescript/test/unit/hooks/hcs-audit-trail-hook.unit.test.ts
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
Signed-off-by: skurzyp-blockydevs <stanislaw.kurzyp@blockydevs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist