Conversation
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
7d43d86 to
13c68e4
Compare
…n an HTS token is created' test Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
…to the same Smart Wallet and send self-sponsored transactions Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
| name: Standard | ||
| name: Standard (${{ matrix.shard }}) | ||
| runs-on: smart-contracts-linux-medium | ||
| strategy: |
There was a problem hiding this comment.
this looks like the same changes we have at https://github.com/hashgraph/hedera-evm-testing/pull/69/changes . We need to merge this branches and resolve conficts
There was a problem hiding this comment.
Yeah, I have made those changes yesterday (to speed up CI?CD) along with many others as part of review comments. In process of merging right now
| */ | ||
| async function associateHtsToken(eoa, tokenAddress, nonce, gasLimit = 1_500_000) { | ||
| const network = await eoa.provider.getNetwork(); | ||
| const receipt = await eoa.sendTransaction({ |
There was a problem hiding this comment.
Another way how you can work with HTS is the follows:
- create
ethers.Interfacefrom HTS artifact like this - create
ethers.ContractwithHTS_ADDRESSlike this - Than you can put resulted
htsContractto some test context and use any function from it directly
This can be applied to any contract calls that we are using.
Really Im ok with both approaches but highlighting for visibility.
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
…a-evm-testing into denys/run-pectra-tests-with-hh
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
lukasz-hashgraph
left a comment
There was a problem hiding this comment.
Just a minor comments. Looks good, thanks!
| * }} params | ||
| * @returns {Promise<import('ethers').TransactionReceipt | null>} | ||
| */ | ||
| async function sendDelegation({ |
There was a problem hiding this comment.
Is this just a specialized version of sendDelegationCreationTx with to and value set o 0?
Also, looks like we're hardcoding nonce to 0. If this method is intended to be used with fresh accounts only we should specify that in the doc.
There was a problem hiding this comment.
Will remove once we have the builder for delegation tx
| * }} params | ||
| * @returns {Promise<import('ethers').TransactionReceipt | null>} | ||
| */ | ||
| async function executeBatchViaDelegation({ |
There was a problem hiding this comment.
Do you think it makes sense to extract some of the logic from those
execute/send txn methods to reusable pieces? Perhaps using the builder pattern?
TransactionBuilder()
.from(sender)
.withProviderNonce()
.addAuthorization(eoa, nonce, targetAddress) // can also set type to 4
.callData(TestSmartWallet.prepareExecuteBatchCallData([target, value, data]))
// etc
There was a problem hiding this comment.
Absolutely, great idea! that would also allow to eliminate the other custom function you mentioned.
…enys/run-pectra-tests-with-hh
Signed-off-by: Denys Sinyakov <denys.sinyakov@swirldslabs.com>
gkozyryatskyy
left a comment
There was a problem hiding this comment.
Reapprove. Thank you @0x-ds !
Description:
This branch expands HIP-1340/EIP-7702 functional coverage, adds Hiero-specific delegation tests, and improves CI runtime by sharding solo-network test execution. It also refactors shared test utilities and updates contract references/helpers to align with current Hedera behavior.
Key Changes:
Added comprehensive HIP-1340 test coverage:
evm-functional-testing/contracts/hip-1340/HasFacadeSelectors.solto mimic behavior of HAS facadeCI optimization in
.github/workflows/evm-functional-testing.yaml:Related issue(s):
Fixes #
Checklist