feat: add local custom networks multisig#1435
Open
jaime-iobermudez wants to merge 10 commits intodevelopfrom
Open
feat: add local custom networks multisig#1435jaime-iobermudez wants to merge 10 commits intodevelopfrom
jaime-iobermudez wants to merge 10 commits intodevelopfrom
Conversation
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
…tom-networks-multisig Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
…tom-networks-multisig Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces support for custom Hedera networks by allowing transactions to specify custom consensus nodes. It refactors the transaction schema, DTOs, and service logic to handle both standard and custom networks, and adds migration scripts and utility functions to facilitate this change. The most important changes are grouped below by theme.
Database and Migration Changes:
1742112000000-AddCustomNetworkSupport.ts) to convert thenetworkcolumn from enum to varchar, and to add aconsensus_nodescolumn for custom network support. The migration handles both upgrade and downgrade scenarios safely.transaction.entity.tsto change thenetworkfield from an enum to a string and added a nullableconsensus_nodesJSONB column.Application Logic and DTO Updates:
Networkenum to includeCUSTOM, and updated transaction DTOs (create-transaction-request.dto.tsandget-transactions-response.dto.ts) to support consensus node specification for custom networks. [1] [2] [3] [4] [5] [6] [7] [8]transaction.service.tsandautoSubmit.service.tsto use a newbuildHederaClientutility, which selects the appropriate network and consensus nodes. [1] [2] [3] [4] [5]Utility and Configuration Changes:
clientFactory.tsutility to build Hedera clients for both standard and custom networks based on provided consensus nodes.package.jsonfor easier database management.app.module.tsto use migrations instead of synchronize, and to automatically run migrations at startup..env.sample.Related issue(s):
Fixes #
Notes for reviewer:
Checklist