Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "endpoint" to "destination" #13226

Merged

Conversation

dhiaayachi
Copy link
Collaborator

Description

This based on the choice to go with "destination" as name for the new external endpoints managed in the terminating gateway

@dhiaayachi dhiaayachi added the pr/no-changelog PR does not need a corresponding .changelog entry label May 25, 2022
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface labels May 25, 2022
@dhiaayachi dhiaayachi added pr/no-metrics-test and removed theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface labels May 25, 2022
@dhiaayachi dhiaayachi requested a review from rboyer May 25, 2022 18:34
@dhiaayachi
Copy link
Collaborator Author

@rboyer assigning this to you too as it's a follow up of #13217

Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏗️ LGTM

@dhiaayachi dhiaayachi merged commit 3c5b85c into egress-gtw/tgtw-gateway-services May 26, 2022
@dhiaayachi dhiaayachi deleted the egress-gtw/rename-destination branch May 26, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants