ci: Run on modern Go and latest Ubuntu runner.#20
Open
jrasell wants to merge 1 commit into
Open
Conversation
| run-tests: | ||
| runs-on: ubuntu-22.04 | ||
| test: | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
Isn't it better to run on fix version to avoid external things affecting the outcome of the tests?
Member
Author
There was a problem hiding this comment.
The library doesn't have any real OS dependency, so using this means we do not have to keep this value updated and is the same approach we are using on other libraries and Go versions (oldstable and stable). The images themselves go through updates that could in theory break tests that rely heavily on OS and installed packages versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://hashicorp.atlassian.net/browse/NMD-1547