fix(vaultsecrets.secrets.create): parse correct secret-type key

[syaghoubi00]

🛠️ Description

Parses correct key from hcp vault-secrets secrets create --secret-type

Parses the literal string static from flag arg

🔗 Additional Link

Closes: #215

🏗️ Local Testing

podman run --rm -it fedora
dnf install -y go
git clone ${REPO}
make go/test
make go/build
echo test | ./bin/hcp vault-secrets secrets create --secret-type=static --data-file=- test_secret

👍 Checklist

• The PR has a descriptive title.
• Input validation updated
• Unit tests updated
• Documentation updated
• Major architecture changes have a corresponding RFC
• Tests added if applicable
• CHANGELOG entry added or label 'pr/no-changelog' added to PR

  Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
  in authoring a changelog entry, and commit the resulting file, which should
  have a name matching your PR number. Entries should use imperative present
  tense (e.g. Add support for...)

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[github-actions]

This PR is more than 2 weeks old. Please remove the stale label, update, or comment if this PR is still valid and relevant, otherwise it will be closed in 7 days.

[syaghoubi00]

Added changelog entry. Is anything else required?

[dhuckins]

hi @syaghoubi00 thanks for the contribution!

this would mean a breaking change for anyone who uses hcp vault-secrets secrets create --secret-type kv, to prevent that from breaking would it be possible to allow both "kv" and "static" as acceptable to create a kv secret?

[syaghoubi00]

@dhuckins I went ahead and preserved the kv opt. This is actually the better fix, because the secretTypeKV is used in more places than I found at first. This will allow the interface to the secretTypeKV to remain consistent in code, while still parsing static from the arg opts.

It might be a good idea to normalize all the opts input, since they are being parsed as string literals. eg. =Static and =STATIC are both 'valid' opts, so adding something like input.ToLowercase might be better for doing the case evals.

hcp/internal/commands/vaultsecrets/secrets/secret_types.go

Lines 6 to 10 in e29db05

	const (
	secretTypeKV = "kv"
	secretTypeDynamic = "dynamic"
	secretTypeRotating = "rotating"
	)