Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing in capabilities results in zero results #222

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

dhuckins
Copy link
Contributor

🛠️ Description

for HCP Vault secrets there is a bug: by passing in capabilities it results in 0 intgrations being returned, user expects to have all integrations returned if no other argument is specified

🔗 Additional Link

🏗️ Local Testing

👍 Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@dhuckins dhuckins marked this pull request as ready for review March 18, 2025 19:12
@dhuckins dhuckins requested a review from a team as a code owner March 18, 2025 19:12
@dhuckins dhuckins merged commit 4c49a66 into main Mar 18, 2025
4 checks passed
@dhuckins dhuckins deleted the dh/integrations-list-bugfix branch March 18, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants