Skip to content

fix(lib): respect hclOutput app config #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jyecusch
Copy link

Related issue

Fixes #3875

Description

Only store and read the hclOutput configuration from the manifest (App class), respecting the value provided in the AppConfig, as well as the SYNTH_HCL_OUTPUT environment variable.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@jyecusch jyecusch requested a review from a team as a code owner May 22, 2025 04:04
@jyecusch jyecusch requested review from mutahhir and ansgarm and removed request for a team May 22, 2025 04:04
Copy link

hashicorp-cla-app bot commented May 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@jyecusch
Copy link
Author

I'm happy to make any changes requested or demo the issue. It may need to be two separate issues, since it would also be nice if the CLI didn't always set the SYNTH_HCL_OUTPUT env var, but running the application directly to get around that is reasonable.

I tried to get the tests running and passing locally following the steps in CONTRIBUTING.md, but I couldn't get them to pass successfully before making changes, so I'm unsure if any tests are broken as a result of this change. I'm happy to fix those too if there are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdktf: AppConfig.hclOutput is ignored
1 participant