Skip to content

Conversation

@sasidhar-aws
Copy link
Contributor

@sasidhar-aws sasidhar-aws commented Oct 23, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add 2 new resources allowing to create networkflowmonitor monitor and scope.

  • aws_networkflowmonitor_monitor
  • aws_networkflowmonitor_scope

Relations

Closes #40890

References

Output from Acceptance Testing

make testacc TESTS=TestAccNetworkFlowMonitorScope_serial
 PKG=networkflowmonitor
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f_aws_networkflow_monitor 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/networkflowmonitor/... -v -count 1 -parallel 20 -run='TestAccNetworkFlowMonitorScope_serial'  -timeout 360m -vet=off
2025/10/21 22:53:19 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/21 22:53:19 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccNetworkFlowMonitorScope_serial
=== PAUSE TestAccNetworkFlowMonitorScope_serial
=== CONT  TestAccNetworkFlowMonitorScope_serial
=== RUN   TestAccNetworkFlowMonitorScope_serial/Scope
=== RUN   TestAccNetworkFlowMonitorScope_serial/Scope/basic
=== RUN   TestAccNetworkFlowMonitorScope_serial/Scope/disappears
=== RUN   TestAccNetworkFlowMonitorScope_serial/Scope/tags
--- PASS: TestAccNetworkFlowMonitorScope_serial (625.69s)
    --- PASS: TestAccNetworkFlowMonitorScope_serial/Scope (625.69s)
        --- PASS: TestAccNetworkFlowMonitorScope_serial/Scope/basic (199.12s)
        --- PASS: TestAccNetworkFlowMonitorScope_serial/Scope/disappears (203.43s)
        --- PASS: TestAccNetworkFlowMonitorScope_serial/Scope/tags (223.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkflowmonitor 631.508s

make testacc TESTS=TestAccNetworkFlowMonitorMonitor_serial PKG=networkflowmonitor
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f_aws_networkflow_monitor 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/networkflowmonitor/... -v -count 1 -parallel 20 -run='TestAccNetworkFlowMonitorMonitor_serial'  -timeout 360m -vet=off
2025/10/23 15:06:05 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/23 15:06:05 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccNetworkFlowMonitorMonitor_serial
=== PAUSE TestAccNetworkFlowMonitorMonitor_serial
=== CONT  TestAccNetworkFlowMonitorMonitor_serial
=== RUN   TestAccNetworkFlowMonitorMonitor_serial/Monitor
=== RUN   TestAccNetworkFlowMonitorMonitor_serial/Monitor/tags
=== RUN   TestAccNetworkFlowMonitorMonitor_serial/Monitor/update
=== RUN   TestAccNetworkFlowMonitorMonitor_serial/Monitor/basic
=== RUN   TestAccNetworkFlowMonitorMonitor_serial/Monitor/disappears
--- PASS: TestAccNetworkFlowMonitorMonitor_serial (3000.71s)
    --- PASS: TestAccNetworkFlowMonitorMonitor_serial/Monitor (3000.71s)
        --- PASS: TestAccNetworkFlowMonitorMonitor_serial/Monitor/tags (790.68s)
        --- PASS: TestAccNetworkFlowMonitorMonitor_serial/Monitor/update (899.22s)
        --- PASS: TestAccNetworkFlowMonitorMonitor_serial/Monitor/basic (594.53s)
        --- PASS: TestAccNetworkFlowMonitorMonitor_serial/Monitor/disappears (716.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkflowmonitor 3006.587s

@sasidhar-aws sasidhar-aws requested a review from a team as a code owner October 23, 2025 18:31
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. service/networkflowmonitor Issues and PRs that pertain to the networkflowmonitor service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. service/networkflowmonitor Issues and PRs that pertain to the networkflowmonitor service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New]: Cloudwatch Network Flow Monitor

1 participant