Fix azuread_privileged_access_group_eligibility_schedule resource update functionality #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the Update functionality to use the adminUpdate: For administrators to change existing eligible assignments. instead of adminAssign: For administrators to assign group membership or ownership eligibility to principals. As per microsoft graph documentation
|
Any luck with merging the PR? |
|
I'm interested in this one too as I've hit the issue where you get 400 errors and are unable to apply after any changes are required. I need to manually delete all the assignments and reapply to make it work which given how slow the azure interface is for this is really painful. |
|
This is definitely the solution we are looking for; total pain in the rear without it at the moment having to recreate role assignments. |
|
An issue for us as well. Looking forward to a solution soon. |
|
PR is ready for review, folks are looking for review/merge status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal with this pull request is to improve the azuread_privileged_access_group_eligibility_schedule resource.
Updating the 'Update' functionality to use the
adminUpdateinstead ofadminAssignAs per Microsoft graph documentationI found this issue in relation to this problem: #1412
As this is my first fork pull request, I hope this way is correct to do it. If not, please let me know so I can improve the pull request.