Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AadApplication and SharepointOnline in resource azuread_access_package_resource_package_association #1627

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jsfr
Copy link

@jsfr jsfr commented Jan 21, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The previous work to implement adding resources to access packages only supported groups (though this isn't mentioned anywhere).

The change to allow both applications and Sharepoint Online though aren't massive, and largely require allowing different IDs as the origin ID.

This PR aims to allow for these two as well, by allowing the access_type to also be a UUID (ID format for app roles) or a URL (seemingly the ID for Sharepoint Online).

Currently, this is a breaking change as it changes the access_type to be required. If we really want this could be avoided, but would mean we keep it defaulting to a value of "Member" which only makes sense for groups.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

Resources changed

  • azuread_access_package_resource_package_association - support for Applications and SharePointOnline, change field access_type to be required and accept UUIDs and URLs.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #1066

@github-actions github-actions bot added size/M and removed size/XS labels Jan 21, 2025
@jsfr jsfr marked this pull request as ready for review January 21, 2025 13:05
@jsfr jsfr requested a review from a team as a code owner January 21, 2025 13:05
@jsfr jsfr changed the title Add support for AadApplication and SharepointOnline in Access Package Resource Role Add support for AadApplication and SharepointOnline in resource azuread_access_package_resource_package_association Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_access_package_resource_package_association only supports groups
1 participant