Add support for AadApplication and SharepointOnline in resource azuread_access_package_resource_package_association
#1627
+100
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
The previous work to implement adding resources to access packages only supported groups (though this isn't mentioned anywhere).
The change to allow both applications and Sharepoint Online though aren't massive, and largely require allowing different IDs as the origin ID.
This PR aims to allow for these two as well, by allowing the
access_type
to also be a UUID (ID format for app roles) or a URL (seemingly the ID for Sharepoint Online).Currently, this is a breaking change as it changes the
access_type
to be required. If we really want this could be avoided, but would mean we keep it defaulting to a value of "Member" which only makes sense for groups.PR Checklist
I have followed the guidelines in our Contributing Documentation.For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.Testing
My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
Resources changed
azuread_access_package_resource_package_association
- support for Applications and SharePointOnline, change fieldaccess_type
to be required and accept UUIDs and URLs.This is a (please select all that apply):
Related Issue(s)
Fixes #1066