Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .github/workflows/checks.yml on v1.8 to roughly match main branch #36736

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Mar 20, 2025

Updating GHAs on the v1.8 branch, as once they get too out of date the GHAs no longer run when you backport changes to that release branch:
Screenshot 2025-03-20 at 17 06 14

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Mar 20, 2025
@SarahFrench SarahFrench changed the title Sarah/update actions v1.8 Update .github/workflows/checks.yml to match main branch Mar 20, 2025
@SarahFrench
Copy link
Member Author

The new vetcheck fails on this branch, so I'll remove that from the diffs

Ideally this commit would make the file align with main@2d6eda28776ff34ed64ebfc176d9feb401a82b79, but that would have meant including the new syncdeps target. This would require adding the syncdeps.sh script to the repo.
@SarahFrench SarahFrench force-pushed the sarah/update-actions-v1.8 branch from 175e4d9 to c12a1ab Compare March 20, 2025 17:23
@SarahFrench SarahFrench marked this pull request as ready for review March 21, 2025 10:38
@SarahFrench SarahFrench changed the title Update .github/workflows/checks.yml to match main branch Update .github/workflows/checks.yml to roughly match main branch Mar 21, 2025
@SarahFrench SarahFrench changed the title Update .github/workflows/checks.yml to roughly match main branch Update .github/workflows/checks.yml on v1.8 to roughly match main branch Mar 21, 2025
@SarahFrench SarahFrench requested a review from a team March 24, 2025 09:44
@SarahFrench SarahFrench merged commit 84d5f62 into v1.8 Mar 24, 2025
10 checks passed
@SarahFrench SarahFrench deleted the sarah/update-actions-v1.8 branch March 24, 2025 11:21

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants