stacks: provide stack and config on component creation #36778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring of the Stacks runtime. No expected behaviour change as a result of these changes.
Previously, nodes in the stacks runtime were created with a single link back to the
mainobject. From the main object they could then search for the stack instance the nodes were linked to. However, the nodes are all created from inside the stack they want to link back to. I found this reverse look up very confusing.After this PR, nodes in the runtime accept both the stack and the configuration they are linked to directly in their constructor. This information is simply always available to them, removing the need for the lookups. I think it is easier to reason about each node and where it lives in the stack with this information made available up front. In addition, we can now create stack instances directly within the embedded stack calls that initialise them, making the tracing of stack instances much easier.