Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include help entry for -replace #36780

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

include help entry for -replace #36780

wants to merge 2 commits into from

Conversation

drewmullen
Copy link
Contributor

@drewmullen drewmullen commented Mar 26, 2025 •
edited
Loading

Fixes #36779

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@drewmullen drewmullen requested a review from a team as a code owner March 26, 2025 16:44
sebasslash
sebasslash requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. We need to add this flag to the docs as well:
website/docs/cli/commands/apply.mdx under Apply Options

@drewmullen
Copy link
Contributor Author

Ill make those changes now - thanks!

@drewmullen drewmullen requested a review from a team as a code owner March 26, 2025 19:09
Uk1288
Uk1288 reviewed Mar 27, 2025
View reviewed changes
Uk1288
Uk1288 previously approved these changes Mar 27, 2025
View reviewed changes
@drewmullen drewmullen requested a review from sebasslash March 27, 2025 14:43
@dbanck dbanck added documentation no-changelog-needed Add this to your PR if the change does not require a changelog entry labels Mar 31, 2025
@dbanck
Copy link
Member

dbanck commented Mar 31, 2025 •
edited
Loading

Nice catch, and thanks for your contribution!

I've added the 'no-changelog' label as we don't normally need changelogs for website or documentation changes. It would be great if you could remove the changelog file. Sorry for the confusion

@drewmullen
Copy link
Contributor Author

no problem, done :) thanks @dbanck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uk1288 Uk1288 Uk1288 left review comments

@sebasslash sebasslash Awaiting requested review from sebasslash

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terraform -help and apply -help do not show -replace options
4 participants
@drewmullen @dbanck @sebasslash @Uk1288