Skip to content

FE-1662: add filter to supply chain - #9684

Open
alex-e-leon wants to merge 33 commits into
mainfrom
FE-1662-add-filter-to-supply-chain
Open

alex-e-leon wants to merge 33 commits into
mainfrom
FE-1662-add-filter-to-supply-chain

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Updates the supply chain pages in hash-frontend with the new filter bars, and updates the filter bar + sort menu with various QOL improvements to work better.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Sep 15, 2026 8:58am UTC
hashdotdesign-tokens Ready Ready Preview Sep 15, 2026 8:58am UTC
petrinaut Ready Ready Preview Sep 15, 2026 8:58am UTC
petrinaut-docs Ready Ready Preview Sep 15, 2026 8:58am UTC

Request Review

@cursor

cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large client-side filtering and table-header UX refactor across multiple site overview views; behavior changes how filters compose with search and tab switching, though logic is covered by new unit tests.

Overview
Replaces per-column filter popovers on the site supply-chain overview with a shared chip-based filter bar (StepFilterBar + step-filters.ts) wired through design-system Filter / FilterGroup. Dwell, planning, trend, and supplier tabs now share one stepFilters state so filters survive tab switches; the opportunities table keeps a separate opportunityFilters set but uses the same filter vocabulary and option building.

Filtering runs upstream in site.tsx (with search applied after), including vendor-specific application and chips disabled or tooltipped when a filter does not apply to the active view. Column-header FilterMenu plumbing is removed (filter-menu.tsx, column-filter.ts); tables use a card layout with a pinned header band that hosts tabs inline with filter + SortMenu, and chip row expansion when filters are active. Sort menus gain additional menu-only metrics; empty states distinguish no data vs no matches via totalCount / generatedCount.

Vitest coverage is added for filter application, applicability, and option building.

Reviewed by Cursor Bugbot for commit 98949ef. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps area/apps > hash.design Affects the `hash.design` design site (app) labels Sep 11, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread apps/hash-frontend/src/pages/supply-chain/supply-chain-data-shell/site.tsx Outdated
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs September 14, 2026 10:00 Inactive
@github-actions github-actions Bot removed the area/infra Relates to version control, CI, CD or IaC (area) label Sep 14, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread libs/@hashintel/ds-components/src/components/Filter/filter.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0a4ea89. Configure here.

Comment thread libs/@hashintel/ds-components/src/components/Filter/filter-util.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/apps > hash* Affects HASH (a `hash-*` app) area/apps area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant