Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently rename ciphertext-related types and functions in sel #182

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Consistently rename ciphertext-related types and functions in sel #182

wants to merge 5 commits into from

Conversation

intricate
Copy link

Resolves #181

In sel, why do we refer to the ciphertext + authentication tag secretbox output as a "hash"? At a glance, this seems like it could be misleading.

@Kleidukos
Copy link
Member

Kleidukos commented Feb 25, 2025 •
edited
Loading

Since this a breaking change of the API, could you introduce a changelog entry (https://github.com/haskell-cryptography/libsodium-bindings/blob/main/sel/CHANGELOG.md) for v0.1.0.0 ? And bump the version in sel.cabal as well?

@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from 669f2d6 to a9159e8 Compare February 25, 2025 22:34
@intricate intricate requested a review from Kleidukos February 25, 2025 22:34
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from a9159e8 to 2b97374 Compare February 26, 2025 12:58
@Kleidukos Kleidukos requested review from kozross and a-02 February 26, 2025 15:03
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from 2b97374 to 2b7b18d Compare February 27, 2025 03:26
@intricate intricate changed the title Rename Sel.SecretKey.Cipher.Hash to Ciphertext Consistently rename ciphertext-related types and functions in sel Feb 27, 2025
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch 2 times, most recently from 4b263cb to 0153e72 Compare February 27, 2025 03:37
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from 0153e72 to b09a7ff Compare February 27, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kleidukos Kleidukos Awaiting requested review from Kleidukos

@kozross kozross Awaiting requested review from kozross

@a-02 a-02 Awaiting requested review from a-02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naming of Sel.SecretKey.Cipher.Hash
2 participants
@intricate @Kleidukos