Skip to content

Conversation

@nattybear
Copy link
Contributor

This PR adds the Read instance to the Scheme data type in BaseUrl by extending the deriving clause.
No other changes are made. This allows parsing Scheme values from strings using the standard Read mechanism.

I understand the drawbacks of using Read, as explained in this link. However, since the readable function in the config-ini library relies on Read, this PR became necessary.

Thank you for allowing this PR.

@tchoutri
Copy link
Contributor

@nattybear Thank you! Could you please add a changelog entry (as shown in https://github.com/haskell-servant/servant/blob/master/CONTRIBUTING.md#changelog-entries)? Other than that, it's good for me. :)

@nattybear
Copy link
Contributor Author

nattybear commented Oct 27, 2025

As requested, I’ve added a file to changelog.d. This PR system is new to me, but it looks really useful!

@tchoutri tchoutri merged commit 610494d into haskell-servant:master Oct 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants