-
Notifications
You must be signed in to change notification settings - Fork 716
Mark Terminate package test as flaky wrt #11087 #11088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cabal-testsuite/PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
Great catch, Brandon! So much for "strong typing" in Haskell. I wish the types didn't allow such mistakes.
Huh? The types _did_ catch it: look at CI.
|
ah, my bad!
On Tue, Jul 22, 2025 at 1:38 PM brandon s allbery kf8nh <
***@***.***> wrote:
… *geekosaur* left a comment (haskell/cabal#11088)
<#11088 (comment)>
Huh? The types _did_ catch it: look at CI.
brandon s allbery kf8nh
***@***.***
On Tue, Jul 22, 2025, 13:35 Artem Pelenitsyn ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Thanks for the patch!
>
> Great catch, Brandon! So much for "strong typing" in Haskell. I wish the
> types didn't allow such mistakes.
>
> —
> Reply to this email directly, view it on GitHub
> <
#11088 (review)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAPRFIFLMHMZ3M3DC3KNK6L3JZY5FAVCNFSM6AAAAACCB2Y3CSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANBUGEYTSMRTGE>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#11088 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUEDWGUSR4BV6EFVV4O7UL3JZZIHAVCNFSM6AAAAACCB2Y3CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBUGAZTCMJUGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
as per https://github.com/haskell/cabal/blob/6d6fc4c772e1b8d3741d63878b8b2a35700fea08/CONTRIBUTING.md#github-pull-request-conventions, the author should set a merge label when they are ready for merging. |
No description provided.