Skip to content

Rework common stanzas in the cabal file generated by cabal init #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+413 −212
Draft

Rework common stanzas in the cabal file generated by cabal init #11261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6716142
Reword common stanzas in the cabal file generated by `cabal init`
Kleidukos Oct 18, 2025
e933e26
Accept golden tests
Kleidukos Oct 28, 2025
795c3db
Don't insert rts options stanza imports for library
Kleidukos Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,5 @@ bench.html

# ignore the downloaded binary files
scripts/release/binary-downloads/

tests/fixtures
5 changes: 4 additions & 1 deletion cabal-install/src/Distribution/Client/Init/FileCreators.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,17 @@ writeProject (ProjectSettings opts pkgDesc libTarget exeTarget testTarget)

let pkgFields = mkPkgDescription opts pkgDesc
commonStanza = mkCommonStanza opts
extensionsStanza = mkExtensionsStanza opts
ghcOptionsStanza = mkGhcOptionsStanza opts
rtsOptionsStanza = mkRtsOptionsStanza opts

libStanza <- prepareLibTarget opts libTarget
exeStanza <- prepareExeTarget opts exeTarget
testStanza <- prepareTestTarget opts testTarget

(reusedCabal, cabalContents) <-
writeCabalFile opts $
pkgFields ++ [commonStanza, libStanza, exeStanza, testStanza]
pkgFields ++ [extensionsStanza, ghcOptionsStanza, rtsOptionsStanza, commonStanza, libStanza, exeStanza, testStanza]

when (null $ _pkgSynopsis pkgDesc) $
message opts T.Warning "No synopsis given. You should edit the .cabal file and add one."
Expand Down
Loading
Loading