Skip to content

Fix analyticsPixel template variable name #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafiles/templates/Html/maintain.html.st
Original file line number Diff line number Diff line change
@@ -50,10 +50,10 @@ package after its been released.
<dd>Reset the fail count and trigger rebuild. Choose this option only if you believe our build process didn't go right for some reason. Reseting fail count won't trigger rebuild if your package has documentation.
<p>$versions:{pkgid|<a href="/package/$pkgid$/reports/reset" onclick="return confirm('Are you sure you want to trigger rebuild?')" >$pkgid$</a>}; separator=", "$</p>
</dd>
<!--

<dt><a href="analytics-pixels">Analytics Pixels</a></dt>
<dd>Maintainers can add analytics pixels to surface information about users of their package.
</dd>
-->

</div>
</body></html>
5 changes: 5 additions & 0 deletions datafiles/templates/Html/package-page.html.st
Original file line number Diff line number Diff line change
@@ -95,6 +95,11 @@
edit package information
</a>
</li>
<li>
<a href="$baseurl$/package/$package.name$/analytics-pixels">
edit package analytics pixels
</a>
</li>
</ul>
<p>Candidates</p>
<ul>
2 changes: 0 additions & 2 deletions datafiles/templates/Users/manage.html.st
Original file line number Diff line number Diff line change
@@ -67,11 +67,9 @@ $tokens:{token|
<li>
<a href="/user/$username$/password">Change your password</a>
</li>
<!--
<li>
<a href="/user/$username$/analytics-pixels">Analytics pixels</a>
</li>
-->
</ul>

</div>
2 changes: 1 addition & 1 deletion src/Distribution/Server/Features/Html.hs
Original file line number Diff line number Diff line change
@@ -1918,7 +1918,7 @@ mkHtmlAnalyticsPixels HtmlUtilities{..} CoreFeature{..} UserFeature{..} UploadFe
template <- getTemplate templates "analytics-pixels-page.html"
return $ toResponse $ template
[ "pkgname" $= pkgname,
"AnalyticsPixels" $= map analyticsPixelUrl (Set.toList analyticsPixels)
"analyticsPixels" $= map analyticsPixelUrl (Set.toList analyticsPixels)
]

userPackagesAnalyticsPixelsHtml :: UserName -> ServerPartE Response