Fix renaming data constructors with fields (resolves #2915, resolves #4083) #4635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulomoon
approved these changes
Jun 16, 2025
|
Wait, it will require some work. It doesn't work as is, yet 😸 |
|
My bad, I saw all the tests have been passed and thought it is ready. Forget to check if the new test have been supplied😆 |
|
Looks promising, but still not 100% done. There's an issue with Record wildcards - the current impl. somehow removes the
|
jhrcek
changed the title
jhrcek
commented
Jun 17, 2025
| @@ -24,6 +24,11 @@ tests :: TestTree | |||
| tests = testGroup "Rename" | |||
| [ goldenWithRename "Data constructor" "DataConstructor" $ \doc -> | |||
| rename doc (Position 0 15) "Op" | |||
| , goldenWithRename "Data constructor with fields" "DataConstructorWithFields" $ \doc -> | |||
| rename doc (Position 1 13) "FooRenamed" | |||
| , knownBrokenForGhcVersions [GHC96, GHC98] "renaming Constructor{..} with RecordWildcard removes .." $ | |||
There was a problem hiding this comment.
Fyi this is a separate new issue I discovered while testing this PR that affects ghc 9.6 and 9.8.
I opened a separate issue to track that: #4636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at resolving #2915 and #4083