Use the HscEnv after summarising the module
#4749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonstrates the issue haskell#4631
Makes sure we don't use the initialised plugins. Fixes haskell#4631.
wz1000
approved these changes
Oct 31, 2025
|
Looks reasonable, but do you know when this started breaking? Is it dependent on the ghc version? |
|
I don't know, unfortunately. It is weird, it seems to be also fixing #4733, which seems to be only an issue with GHC 9.12 and not on GHC 9.10. |
|
Using the test case, I could try to bisect the regression. |
|
Plugins are definitely broken for all supported GHC versions, but I don't know for how long already. |
|
Thanks for investigating, I don't think this warrant too much further effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4631