Repository navigation
Show module haddock documentation on hover for imports - #5124
Merged
Merged
Conversation
julianjumper
changed the title
VeryMilkyJoe
requested changes
Oct 11, 2026
VeryMilkyJoe
left a comment
VeryMilkyJoe
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me, it would be nice to see a gif of it in action, otherwise you can also come find me at the hls table and show me on your pc 🙃
VeryMilkyJoe
approved these changes
Oct 11, 2026
VeryMilkyJoe
left a comment
VeryMilkyJoe
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just one nit :)
| @@ -1 +1 @@ | |||
| cradle: {direct: {arguments: ["Foo", "Bar", "GotoHover", "RecordDotSyntax", "GotoImplementation", "Constructors", "ConstructorsLinear"]}} | |||
| cradle: {direct: {arguments: ["Foo", "Bar", "GotoHover", "RecordDotSyntax", "GotoImplementation", "Constructors", "ConstructorsLinear", "DocSource", "DochTarget"]}} | |||
Collaborator
There was a problem hiding this comment.
What does this do? It looks like a typo :)
Contributor
There was a problem hiding this comment.
Yes it is, no idea why this does not affect anything. Fixed it, and the tests still pass.
Contributor
|
Demo Video for Presenting at MuniHac: here |
VeryMilkyJoe
enabled auto-merge (squash)
October 11, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show module haddock documentation on hover on import
Closes issue #5023