Workaround DST issues in toClockTime . toUTCTime, at least in some cases
#23
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cases To add months and years `addToClockTime` converts clock time to calendar time and then back. As reported at #18, there seems to be some issues with accounting for daylight saving time, which manifest themselves in `addToClockTime noTimeDiff` actually shifting the time by one hour. The implementation of `toClockTime` certainly takes shortcuts, but I'd rather not to touch it, there is not enough test coverage. Instead this patch implements a workaround, eliminating the issue in many practical scenarios: if months and years to be added are zero then just skip conversion to calendar time and back.
andreasabel
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add months and years
addToClockTimeconverts clock time to calendar time and then back.As reported at #18, there seems to be some issues with accounting for daylight saving time, which manifest themselves in
addToClockTime noTimeDiffactually shifting the time by one hour.The implementation of
toClockTimecertainly takes shortcuts, but I'd rather not to touch it, there is not enough test coverage. Instead this patch implements a workaround, eliminating the issue in many practical scenarios: if months and years to be added are zero then just skip conversion to calendar time and back.