Skip to content

Fix: DAG output bug#3689

Open
mrkaye97 wants to merge 12 commits intomainfrom
mk/fix-dag-output-bug
Open

Fix: DAG output bug#3689
mrkaye97 wants to merge 12 commits intomainfrom
mk/fix-dag-output-bug

Conversation

@mrkaye97
Copy link
Copy Markdown
Contributor

@mrkaye97 mrkaye97 commented Apr 23, 2026

Description

Right now DAGs in the dashboard only show the output of one of the tasks, and the goal here is to show something similar to what you'd see after calling .run in the SDK

E.g.:

Screenshot 2026-04-23 at 1 56 53 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hatchet-docs Ready Ready Preview, Comment Apr 27, 2026 9:19pm

Request Review

@mrkaye97 mrkaye97 marked this pull request as ready for review April 23, 2026 18:02
Copilot AI review requested due to automatic review settings April 23, 2026 18:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where DAG workflow runs in the dashboard only surfaced the output for a single task by persisting a per-task step name and using it to assemble a composite workflow-run output similar to SDK .run() results.

Changes:

  • Add step_name to core (v1_task) and OLAP (v1_tasks_olap) schemas + migration.
  • Propagate step_name through task creation paths and sqlc-generated queries/models.
  • Update OLAP workflow-run read logic to build an output object keyed by step name using finished output payloads.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sql/schema/v1-olap.sql Adds step_name column to OLAP tasks table schema.
sql/schema/v1-core.sql Adds step_name column to core v1_task schema.
cmd/hatchet-migrate/migrate/migrations/20260423164911_v1_0_99.sql Migration to add/drop step_name on core + OLAP task tables.
pkg/repository/task.go Writes step_name when inserting tasks (plumbed into CreateTasks params).
pkg/repository/olap.go Builds workflow-run output from per-task finished payloads keyed by step_name.
pkg/repository/sqlcv1/olap.sql Inserts step_name into OLAP tasks and enriches workflow-run metadata JSON with step/output event info.
pkg/repository/sqlcv1/olap.sql.go Regenerated sqlc code reflecting OLAP query/schema changes (incl. step_name).
pkg/repository/sqlcv1/tasks-overwrite.go Extends CreateTasks SQL and params with step_name.
pkg/repository/sqlcv1/tasks.sql.go Regenerated sqlc code reflecting core task schema/query changes (incl. step_name).
pkg/repository/sqlcv1/workers.sql.go Regenerated sqlc code reflecting added step_name selection.
pkg/repository/sqlcv1/durable_event_log.sql.go Regenerated sqlc code reflecting added step_name selection.
pkg/repository/sqlcv1/models.go Adds StepName to sqlc models for v1_task and v1_tasks_olap.
pkg/repository/sqlcv1/copyfrom.go Includes step_name in OLAP CopyFrom insert for tasks.
pkg/repository/sqlcv1/batch.go Updates batch query to include step_name.

Comment thread pkg/repository/olap.go
Comment thread pkg/repository/olap.go
Comment thread pkg/repository/sqlcv1/tasks-overwrite.go
Comment thread cmd/hatchet-migrate/migrate/migrations/20260428164911_v1_0_102.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants