Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This reverts commit 518993d.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where DAG workflow runs in the dashboard only surfaced the output for a single task by persisting a per-task step name and using it to assemble a composite workflow-run output similar to SDK .run() results.
Changes:
- Add
step_nameto core (v1_task) and OLAP (v1_tasks_olap) schemas + migration. - Propagate
step_namethrough task creation paths and sqlc-generated queries/models. - Update OLAP workflow-run read logic to build an output object keyed by step name using finished output payloads.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sql/schema/v1-olap.sql | Adds step_name column to OLAP tasks table schema. |
| sql/schema/v1-core.sql | Adds step_name column to core v1_task schema. |
| cmd/hatchet-migrate/migrate/migrations/20260423164911_v1_0_99.sql | Migration to add/drop step_name on core + OLAP task tables. |
| pkg/repository/task.go | Writes step_name when inserting tasks (plumbed into CreateTasks params). |
| pkg/repository/olap.go | Builds workflow-run output from per-task finished payloads keyed by step_name. |
| pkg/repository/sqlcv1/olap.sql | Inserts step_name into OLAP tasks and enriches workflow-run metadata JSON with step/output event info. |
| pkg/repository/sqlcv1/olap.sql.go | Regenerated sqlc code reflecting OLAP query/schema changes (incl. step_name). |
| pkg/repository/sqlcv1/tasks-overwrite.go | Extends CreateTasks SQL and params with step_name. |
| pkg/repository/sqlcv1/tasks.sql.go | Regenerated sqlc code reflecting core task schema/query changes (incl. step_name). |
| pkg/repository/sqlcv1/workers.sql.go | Regenerated sqlc code reflecting added step_name selection. |
| pkg/repository/sqlcv1/durable_event_log.sql.go | Regenerated sqlc code reflecting added step_name selection. |
| pkg/repository/sqlcv1/models.go | Adds StepName to sqlc models for v1_task and v1_tasks_olap. |
| pkg/repository/sqlcv1/copyfrom.go | Includes step_name in OLAP CopyFrom insert for tasks. |
| pkg/repository/sqlcv1/batch.go | Updates batch query to include step_name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now DAGs in the dashboard only show the output of one of the tasks, and the goal here is to show something similar to what you'd see after calling
.runin the SDKE.g.:
Type of change