fix: Slow cold start when workflows are inactive > 1 day#3830
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Benchmark resultsCompared against |
Contributor
Author
|
The failing e2e test fails on main as well, so not related to these changes. |
grutt
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a workflow is triggered that was last triggered > 1 day prior, the call to
l.lr.ListQueuesinacquireQueueLeasesdoes not pick up that workflow's queue lease.acquireQueueLeasesis called with a polling interval of 5 seconds, which means that if a workflow is triggered, it would have to wait up to 5 seconds beforeacquireQueueLeaseswill be called, pick up the queue lease, notify the tenant manager, and finally haveaddQueuerget called inTenantManager.listenForQueueLeasesto actually create the queue and have it get picked up inrunOptimisticScheduling. This PR changes the logic in the TenantManager such that when acheck-tenant-queuemessage is received, instead of just waking up the existing queues that exist in memory, it also creates new queues for queues that do not exist in memory, thus avoiding the aforementioned wait for the acquireQueueLeases poll.Fixes # (issue)
Type of change
What's Changed