You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plan here is to prepare to re-partition v1_payload and update its PK to use inserted_at_date, so we can enforce a more genuine "unique" constraint on (external_id, inserted_at_date) (which is extremely unlikely to collide by chance.
Fixes # (issue)
Type of change
Bug fix (non-breaking change which fixes an issue)
Refactor (non-breaking changes to code which doesn't change any behaviour)
Adds and backfills v1_payload.inserted_at_date in preparation for date-aware partitioning and uniqueness.
Introduces a resumable, non-transactional batched backfill and then enforces NOT NULL.
Populates the date from inserted_at for new payload writes.
Updates the schema and generated sqlc model/read mappings for the new column.
Confidence Score: 5/5
The PR appears safe to merge with no concrete blocking or non-blocking defects identified.
The migration's rerun behavior is coherent, current writes derive the new value from inserted_at, and the generated model, SELECT order, scan destinations, and INSERT columns remain consistent.
鈿狅笍Optional test failure: The load-online-migrate job failed on this PR. This check is non-mandatory and does not block merging, but may be worth investigating. View logs
鈿狅笍Optional test failure: The load-online-migrate job failed on this PR. This check is non-mandatory and does not block merging, but may be worth investigating. View logs
鈿狅笍Optional test failure: The load-online-migrate job failed on this PR. This check is non-mandatory and does not block merging, but may be worth investigating. View logs
鈿狅笍Optional test failure: The load-online-migrate job failed on this PR. This check is non-mandatory and does not block merging, but may be worth investigating. View logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engineRelated to the core Hatchet enginesdk-pyRelated to the Python sdk
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The plan here is to prepare to re-partition
v1_payloadand update its PK to useinserted_at_date, so we can enforce a more genuine "unique" constraint on(external_id, inserted_at_date)(which is extremely unlikely to collide by chance.Fixes # (issue)
Type of change
Checklist
Changes have been:
馃 AI Disclosure