Fix CANCEL_IN_PROGRESS replacement during retry backoff - #4903
Draft
Scalahansolo wants to merge 1 commit into
Draft
Scalahansolo wants to merge 1 commit into
Scalahansolo wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep filled CANCEL_IN_PROGRESS slots attached to the current retry during backoff, preserving replacement ownership and ordering. Remove pending retries atomically when their retained slots are cancelled, and reuse retained slots when retries become eligible. Includes a reversible database migration.
Adds database regressions for workflow and single-task declarations, future and already-due retries, cancellation before asynchronous delivery, and ordinary retry admission on another key. All four cases fail without the change; the concurrency integration suite and concurrency unit tests pass with it. Migration rollback was also exercised with a pending retained retry.
Draft: the standalone first-step and durable-wait → later-step reproductions pass on v0.105.16 with the SQL fix backported. End-to-end validation on current main is blocked by a separate first-task dispatch failure that also occurs with this migration rolled back. Concurrent retry-admission interleavings and chained-policy retry coverage still need validation before this is ready.
Fixes #4900