[ruby] Replace #size with #length to Prevent Unexpected Behaviour in the Case of Integer #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayat01sh1da
deleted the
hayat01sh1da/ruby/replace-size-with-length-to-prevent-unexpected-behaviour-in-the-case-of-integer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the receiver is one of Array, Hash or String, there is basically no difference in terms of return value which represents the number of elements.
However, if it's of Integer, it returns the number of bytes in the machine representation of self; the value is system-dependent.
It may cause unexpected behaviours, so it should be replaced with #length because
Integer#lengthraisesNoMethodError.Ref. https://docs.ruby-lang.org/en/master/Integer.html#method-i-size