Migrate get-distribution-variants to docker-actions [DI-580]
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishaatr
approved these changes
Nov 20, 2025
Contributor
nishaatr
left a comment
nishaatr
left a comment
There was a problem hiding this comment.
feels overkill (also considering have to run bash to do nothing)
potentially could go into some shared scripts but that would still need fetching
just saying!
|
|
||
| outputs: | ||
| classifiers: | ||
| value: '["slim", ""]' |
Contributor
There was a problem hiding this comment.
small comment as to why "" would be good!
ldziedziul
requested changes
Dec 5, 2025
Contributor
ldziedziul
left a comment
ldziedziul
left a comment
There was a problem hiding this comment.
Please add even a simplistic test-get-distribution-variants.yml to catch silly issues like typos.
JackPGreen
added a commit
that referenced
this pull request
Dec 5, 2025
JackPGreen
added a commit
that referenced
this pull request
Dec 5, 2025
JackPGreen
force-pushed
the
migrate-get-distribution-matrix
branch
from
776955b to
4436770
Compare
JackPGreen
force-pushed
the
migrate-get-distribution-matrix
branch
from
4436770 to
37561d9
Compare
Contributor
Author
|
ldziedziul
reviewed
Dec 5, 2025
Co-authored-by: Łukasz Dziedziul <[email protected]>
|
ldziedziul
approved these changes
Dec 5, 2025
JackPGreen
added a commit
to hazelcast/hazelcast-docker
that referenced
this pull request
Dec 5, 2025
See hazelcast/docker-actions#29 Changes: - migrated `get-distribution-variants` workflow to `docker_actions` - simplified output of `get-distribution-variants` to simply output the classifier, not also the suffix (derived from the classifier) - updated `get-tags-to-push` to support a classifier input (what it actually expected) instead of a generic `SUFFIX` input - dynamically computed the `SUFFIX` in the only place we _actually_ need it [Successful PR execution when pointing at the new `docker-actions` branch](https://github.com/hazelcast/hazelcast-docker/actions/runs/19537701012) - now it's pointing at `master`, will fail until merged. _Partially addresses_: [DI-580](https://hazelcast.atlassian.net/browse/DI-580) [DI-580]: https://hazelcast.atlassian.net/browse/DI-580?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hazelcast/hazelcast-docker#1165
Changes:
Partially addresses: DI-580