Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global undo #1543

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Global undo #1543

wants to merge 2 commits into from

Conversation

Negabinary
Copy link
Contributor

This pr shows a design for a global log / undo / redo that will work even when we split up our model into multiple incrementally calculated Bonsai models.

The basic architecture is that each component keeps track of its own undo history, and then a global "undo controller" keeps track of a list of which order components need to undo in.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.35%. Comparing base (4390190) to head (494d987).

Files with missing lines Patch % Lines
src/util/Aba.re 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1543      +/-   ##
==========================================
+ Coverage   50.33%   50.35%   +0.01%     
==========================================
  Files         103      103              
  Lines       10442    10446       +4     
==========================================
+ Hits         5256     5260       +4     
  Misses       5186     5186              
Files with missing lines Coverage Δ
src/util/Aba.re 59.67% <0.00%> (-4.12%) ⬇️

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant