Repository navigation
feat(view): show and toggle the sort direction in View options - #11086
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
Since hcengineering#9926 the sort direction could only be reversed by choosing the already selected Ordering entry again, with nothing showing the current direction, so users could neither see nor discover it. Add a small direction button next to the Ordering dropdown in the View options popup. It reuses the table header sort icon, shows an Ascending/Descending tooltip and reverses the order when clicked. Choosing the active entry again still reverses the order. Manual (rank) ordering follows the drag-and-drop order, so the button is hidden for it and choosing Manual again no longer stores a reversed manual order. The selection logic moved into a small helper with unit tests and no longer mutates the configured default order option. Fixes hcengineering#7346 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7346
Problem
Since #9926 the sort direction can be reversed by picking the already-selected "Ordering" entry again, but nothing shows the current direction, so the feature is neither visible nor discoverable.
Changes
orderDirection.ts; new stringsAscending/Descendingin allview-assetslocales.Tests
orderDirection.test.ts(6 cases). Manual: Tracker → Issues → View options → click the direction button → order reverses and persists after reload; "Manual" ordering hides the button.