Repository navigation
feat(text-editor): find the separator line slash command by 'divider' and 'hr' - #11092
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
… and 'hr' The slash command popup filters items only by their translated label, so typing /divider or /hr (common names in other markdown editors) found nothing; only 'Separator line' matched. SelectPopupValueType gets an optional keywords list, SelectPopup matches the search term against the label/text and these keywords via a small matchesSearch helper, and the separator line inline command declares 'divider' and 'hr' as keywords. Covered by a unit test for matchesSearch. Fixes hcengineering#9326 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9326
Problem and change
The slash command popup filters items only by their translated label, so typing /divider or /hr (common names in other markdown editors) found nothing; only 'Separator line' matched.
SelectPopupValueType gets an optional keywords list, SelectPopup matches the search term against the label/text and these keywords via a small matchesSearch helper, and the separator line inline command declares 'divider' and 'hr' as keywords. Covered by a unit test for matchesSearch.
Tests
matchesSearch.test.ts. Manual: in an editor,/dividerand/hroffer "Separator line";/sepstill works. Items without keywords filter exactly as before.