Repository navigation
fix(pulse): detect dead websockets and back off reconnects - #11097
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
HulypulseClient and PresenceClient recreated their 5 minute ping timeout on every 30 second ping tick, so the timeout was always cleared before it could fire. HulypulseClient additionally only closed the socket when it was not OPEN, so a half-open connection that stopped answering pings was never detected, and both clients reconnected on a fixed 1 second timer. The dead-connection timeout is now started on connect and reset only when a message (including pong) is received from the server. When it fires, the stale socket is detached and closed and a reconnect is scheduled; late events from the detached socket are ignored, so no second reconnect is started. Reconnects use exponential backoff capped at 30 seconds with jitter (getReconnectDelay, shared via @hcengineering/hulypulse-client), reset after a successful connect. Sending a request no longer restarts the ping timer. Fixes hcengineering#10946 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10946
Problem and change
HulypulseClient and PresenceClient recreated their 5 minute ping timeout on
every 30 second ping tick, so the timeout was always cleared before it could
fire. HulypulseClient additionally only closed the socket when it was not
OPEN, so a half-open connection that stopped answering pings was never
detected, and both clients reconnected on a fixed 1 second timer.
The dead-connection timeout is now started on connect and reset only when a
message (including pong) is received from the server. When it fires, the
stale socket is detached and closed and a reconnect is scheduled; late events
from the detached socket are ignored, so no second reconnect is started.
Reconnects use exponential backoff capped at 30 seconds with jitter
(getReconnectDelay, shared via @hcengineering/hulypulse-client), reset after a
successful connect. Sending a request no longer restarts the ping timer.
Tests
client.test.tswith fake timers and a fake WebSocket (pings every 30 s, dead socket closed and reopened after 5 min without replies, pongs keep the connection, capped backoff, no reconnect after close). The hulypulse server answers textpingwithpong; the presence client relies on the same contract it already expected (the presence server is not part of this repository).