Repository navigation
fix(tracker): do not show done or canceled issues as overdue - #11098
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
The tracker due date presenter and editor decided whether to suppress the overdue warning only from value.$lookup.status. Most places that render them (issue edit control panel, Gantt quick info, Kanban cards, list views without a status lookup) pass the plain issue, so the status category was unknown and done/canceled issues with a past due date were still shown as overdue. Resolve the status from the shared status store by value.status and fall back to the lookup, the same way task's DueDateEditor and the lead/recruit Kanban cards already do. Fixes hcengineering#8906 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8906
Problem and change
The tracker due date presenter and editor decided whether to suppress the
overdue warning only from value.$lookup.status. Most places that render
them (issue edit control panel, Gantt quick info, Kanban cards, list views
without a status lookup) pass the plain issue, so the status category was
unknown and done/canceled issues with a past due date were still shown as
overdue.
Resolve the status from the shared status store by value.status and fall
back to the lookup, the same way task's DueDateEditor and the lead/recruit
Kanban cards already do.
Tests
Manual: an issue with a past due date shows the overdue style; set to Done or Canceled → normal in the list, Kanban card and issue side panel; back to In Progress → overdue again.