Repository navigation
fix(text-editor): link popup breaks in browsers without URL.canParse - #11099
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
URL.canParse is only available since Chrome 120 / Safari 17. On older browsers the reactive canSave check in LinkPopup threw a TypeError, so the link dialog could neither be saved nor closed. Reference URL parsing in the reference extension used the same API.
Add a small canParseUrl helper based on try { new URL() } catch and use it in LinkPopup and the reference extension, with a unit test.
Fixes hcengineering#8849
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8849
Problem and change
URL.canParse is only available since Chrome 120 / Safari 17. On older browsers the reactive canSave check in LinkPopup threw a TypeError, so the link dialog could neither be saved nor closed. Reference URL parsing in the reference extension used the same API.
Add a small canParseUrl helper based on try { new URL() } catch and use it in LinkPopup and the reference extension, with a unit test.
Tests
url.test.ts. Manual: select text → Link → enter a URL → Save, also afterdelete URL.canParsein the console (simulating an older browser).