Repository navigation
fix(contact): do not allow kicking yourself out of the workspace - #11100
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
The "Kick employee" context action had no check for the current user, so it was offered on your own employee and removed your own account from the workspace (the account service treats a self-removal as a regular leave), locking you out. Add a CanKickEmployee visibility tester that hides the action for the current user's own employee, and make the action implementation a no-op for the current user as a second guard. Leaving a workspace remains available through "Leave workspace" in the profile settings, which also handles the last-owner case. The check is a small pure helper covered by unit tests; enable jest for contact-resources. Fixes hcengineering#7429 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7429
Problem and change
The "Kick employee" context action had no check for the current user, so it was offered on your own employee and removed your own account from the workspace (the account service treats a self-removal as a regular leave), locking you out.
Add a CanKickEmployee visibility tester that hides the action for the current user's own employee, and make the action implementation a no-op for the current user as a second guard. Leaving a workspace remains available through "Leave workspace" in the profile settings, which also handles the last-owner case. The check is a small pure helper covered by unit tests; enable jest for contact-resources.
Tests
kickEmployee.test.ts(the package now runs its jest tests). Manual: Contacts → Employee → right-click your own employee: no "Kick employee"; another active employee still has it.