Repository navigation
feat(view): allow resetting document and teamspace icons to default - #11109
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
Once a document or teamspace icon was changed to an emoji or another icon/color, the IconPicker offered no way back to the default icon, and callers only ever wrote new icon/color values, so the original default could not be restored.
IconPicker gets an opt-in showReset prop that renders a "Reset to default" button; it closes the picker with { icon: undefined, color: undefined }. EditDoc unsets icon and color on the document via $unset (undefined values are not persisted by an update), CreateDocument clears the pending values, and CreateTeamspace clears the icon and restores the name-derived color, unsetting the icon when editing an existing teamspace. Other IconPicker users are unchanged. Adds the ResetToDefault string to all view-assets languages.
Fixes hcengineering#6883
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6883
Problem and change
Once a document or teamspace icon was changed to an emoji or another icon/color, the IconPicker offered no way back to the default icon, and callers only ever wrote new icon/color values, so the original default could not be restored.
IconPicker gets an opt-in showReset prop that renders a "Reset to default" button; it closes the picker with { icon: undefined, color: undefined }. EditDoc unsets icon and color on the document via $unset (undefined values are not persisted by an update), CreateDocument clears the pending values, and CreateTeamspace clears the icon and restores the name-derived color, unsetting the icon when editing an existing teamspace. Other IconPicker users are unchanged. Adds the ResetToDefault string to all view-assets languages.
Tests
No unit test (Svelte wiring only). Checked manually on a self-hosted instance: set an emoji on a document, reload, "Reset to default" restores the default document icon (also after reload); same in the New teamspace dialog.