Repository navigation
fix(activity): keep short messages whole in backlinks and mark truncated ones - #11127
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
…ted ones When a document was mentioned, the backlink (ActivityReference) stored only the block that contained the mention, so the rest of a short message was lost and for long messages nothing showed that the text was cut. getReferencesData now builds the backlink message via getReferenceMessage: messages with up to 500 characters of text are kept as a whole; for longer ones only the block containing the mention is kept and an ellipsis is appended. Single-block messages are stored as before. Fixes hcengineering#9046 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9046
Problem and change
When a document was mentioned, the backlink (ActivityReference) stored only the
block that contained the mention, so the rest of a short message was lost and
for long messages nothing showed that the text was cut.
getReferencesData now builds the backlink message via getReferenceMessage:
messages with up to 500 characters of text are kept as a whole; for longer ones
only the block containing the mention is kept and an ellipsis is appended.
Single-block messages are stored as before.
Tests
New cases in
server-plugins/activity-resources/src/__tests__/references.test.ts(short multi-paragraph message kept whole, exactly 500 and 501 characters). Checked manually on a self-hosted instance: a two-paragraph message mentioning an issue shows both paragraphs in the issue's backlink; with a long first paragraph only the mention paragraph is shown, ending with " …"; single-paragraph mentions look as before.