Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate button to hide unhide archived vacancies #4154

Closed

Conversation

Syarg
Copy link
Contributor

@Syarg Syarg commented Dec 6, 2023

Contribution checklist

Brief description

Added separate button to vacancies view to enable/disable filtering out archived vacancies in single click.
In original code there was a stub permanently hiding archived vacancies, overriding applied filters.
image
image

Checklist

  • [+] - UI test added to added/changed functionality?
  • [+] - Screenshot is added to PR if applicable ?
  • [+] - Does a local formatting is applied (rush format)
  • [+] - Does a local svele-check is applied (rush svelte check)
  • [+] - Does a local UI tests are executed UI Testing
  • [+] - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • [+] - Does the translations are up to date?
  • [+] - Does it well tested?
  • [+] - Tested for Chrome.
  • [+] - Tested for Safari.
  • [+] - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • [+] - Is there any redundant or duplicate code?
  • [+] - Are required links are linked to PR?
  • [+] - Does new code is well documented ?

Related issues

#4003

Contributor requirements

  • [+] - Sign-off is provided. DCO
  • [+] - GPG Signature is provided. GPG

@haiodo haiodo self-assigned this Dec 7, 2023
@haiodo
Copy link
Member

haiodo commented Dec 7, 2023

@Syarg Thanks for contribution, but I personally think we need to make in one style with other switchers, and also in this scenario we need to get rid of Archive for only archived vacancies.

image

What I mean.
image

So by default it could be Hide Archived Vacancies.

Thanks.

@Syarg Syarg closed this Dec 18, 2023
@Syarg Syarg force-pushed the vacancies-explicit-hide-archived-#4003 branch from 93b3d61 to 89706eb Compare December 18, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants