Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide archieved vacanies toggle in viewoptions #4220

Merged
merged 18 commits into from
Dec 21, 2023
Merged

hide archieved vacanies toggle in viewoptions #4220

merged 18 commits into from
Dec 21, 2023

Conversation

Syarg
Copy link
Contributor

@Syarg Syarg commented Dec 19, 2023

image
image
image

Contribution checklist

Brief description

Hide archieved vacancies toogle for View options for vacancies.

Checklist

  • [+] - UI test added to added/changed functionality?
  • [+] - Screenshot is added to PR if applicable ?
  • [+] - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • [+] - Does a local UI tests are executed UI Testing
  • [+] - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • [+] - Does the translations are up to date?
  • [+] - Does it well tested?
  • [+] - Tested for Chrome.
  • [+] - Tested for Safari.
  • [+] - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • [+] - Is there any redundant or duplicate code?
  • [+] - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

#4003

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@Syarg Syarg requested a review from haiodo December 19, 2023 05:19
@Syarg Syarg force-pushed the vacancies-explicit-hide-archived-viewoptions-#4003 branch from b0b73ee to 38a3ff1 Compare December 19, 2023 09:52
Syarg and others added 17 commits December 20, 2023 21:11
@Syarg
hide archieved vacanies toggle in viewoptions
e9b1042 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
formatting fix
aea234f 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
formatting fix
8b4d098 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
fixed test case
3f69c16 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
fix formatting
88aba87 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
formatting fix
07541e6 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
formatting fix
02b92d2 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@haiodo @Syarg
UBER-1182: Fix github task types support (hcengineering#4215)
8f3c09f 
Signed-off-by: Andrey Sobolev <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@nestoragent @Syarg
feat(tests): TESTS-81 done Comment stored test (hcengineering#4216)
fff09c6 
Signed-off-by: Alex Velichko <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@nestoragent @Syarg
feat(tests): updated flaky tests (hcengineering#4218)
c6d007d 
Signed-off-by: Alex Velichko <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@nestoragent @Syarg
feat(tests): TESTS-106 (hcengineering#4217)
7f4932b 
Signed-off-by: Alex Velichko <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@nestoragent @Syarg
feat(tests): TESTS-41 done Delete a sub-issue test (hcengineering#4223)
15e4183 
Signed-off-by: Alex Velichko <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@sol-0 @Syarg
Radio button marker is always displayed in disabled state (hcengineer…
c6e5f0b 
…ing#4204)

Signed-off-by: Oleg Solodkov <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@nestoragent @Syarg
TESTS-59: feat(tests): done Create an Issue from template test (hceng…
b7f559a 
…ineering#4212)

Signed-off-by: Alex Velichko <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@nestoragent @Syarg
feat(tests): updated tests (hcengineering#4224)
51ea531 
Signed-off-by: Alex Velichko <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@haiodo @Syarg
UBER-1182: Fix task type categories (hcengineering#4222)
fe95653 
Signed-off-by: Andrey Sobolev <[email protected]>
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg
removed archive from recruit nav
7b92f16 
Signed-off-by: Sergey Voytsehovich <[email protected]>
@Syarg Syarg force-pushed the vacancies-explicit-hide-archived-viewoptions-#4003 branch from 8513cd8 to 7b92f16 Compare December 20, 2023 18:12
@haiodo haiodo merged commit c705fd3 into hcengineering:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Syarg @haiodo @nestoragent @sol-0