Tracker filters #9298
Tracker filters #9298
Conversation
|
Connected to Huly®: UBERF-11658 |
rostislavnagimov
force-pushed
the
tracker_filters
branch
from
013c7c9 to
b975cd1
Compare
| let resultQuery: DocumentQuery<Issue> = { ...searchQuery } | ||
| function saveTrackerIssueState (): void { | ||
| console.log('[DEBUG_STATE_ISSUES] Save State: Starting for tab', currentTabId) |
There was a problem hiding this comment.
Cleaned up
| import { Viewlet } from '@hcengineering/view' | ||
| import ViewletSelector from './ViewletSelector.svelte' | ||
| import FilterButton from './filter/FilterButton.svelte' | ||
| import { WorkbenchTab } from '../../../workbench/types' |
There was a problem hiding this comment.
No. You can't use workbench types in view, because workbench depends on view... You should extract it to the view package, or use Ref instead
There was a problem hiding this comment.
This actually indicates the problem with the approach - the header and button components know on which tab rendered, which is not correct per my point of view.
There was a problem hiding this comment.
Moved the logic to the Workbench layer, keeping all the View components pure
rostislavnagimov
force-pushed
the
tracker_filters
branch
2 times, most recently
from
99a8066 to
1dc152c
Compare
|
Can you explain the idea, how this works? |
We save the filter state in a store with a tabId relation and restore the state when user gets back on a tab. That is the basic idea. |
Signed-off-by: Rostislav Nagimov <[email protected]>
rostislavnagimov
force-pushed
the
tracker_filters
branch
2 times, most recently
from
82dff5d to
b40ddc1
Compare
Signed-off-by: Rostislav Nagimov <[email protected]>
3 participants
The issue: filters in a tracker were set globally, so if you have two same tabs you cannot set two different set of filters (and some people in a product_feedback were asking to have this feature).