Skip to content

Enable "Show IPs" option for GNOME version >= 40 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c84c wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable "Show IPs" option for GNOME version >= 40 #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e25f187
Enable "Show IPs" option for gnome version >= 40
c84c Sep 9, 2021
411bfc6
better logging
c84c Jan 14, 2023
722a5a5
fix: show ips follow prefs
c84c Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ function canShowIPs() {

let version_array = splitVersion(Config.PACKAGE_VERSION);

if (version_array[0] == 3 && (version_array[1] < 28 || version_array[1] >= 34)) {
getLogger().debug(`Show IP can be enabled. Gjs version: '${Config.PACKAGE_VERSION}'`);
if (version_array[0] >= 40 || (version_array[0] == 3 && (version_array[1] < 28 || version_array[1] >= 34))) {
getLogger().debug(`Show IP can be enabled. Gjs version: '${Config.PACKAGE_VERSION}' - Parsed: ${version_array[0]}.${version_array[1]} - Compared: ${version_array[0] >= 40}`);
return true;
}
getLogger().warning(`Show IP cannot be enabled. Gjs version: '${Config.PACKAGE_VERSION}'`);
Expand Down
10 changes: 9 additions & 1 deletion net_speed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,14 @@ var NetSpeed = class NetSpeed {
this.menu_label_size = this._setting.get_int('menu-label-size');
this.use_bytes = this._setting.get_boolean('use-bytes');
this.bin_prefixes = this._setting.get_boolean('bin-prefixes');
this.show_ips = this._setting.get_boolean('show-ips');
this.vert_align = this._setting.get_boolean('vert-align');

let show_ips = this._setting.get_boolean('show-ips');
if (show_ips !== this.show_ips && show_ips) {
// trigger ip reload
this._trigger_ips_reload();
}
this.show_ips = show_ips;
}

/**
Expand Down Expand Up @@ -364,6 +370,8 @@ var NetSpeed = class NetSpeed {
let schema = schemaSource.lookup('org.gnome.shell.extensions.netspeed', false);
this._setting = new Gio.Settings({ settings_schema: schema });
this._saving = 0;
this.show_ips = this._setting.get_boolean('show-ips');

this._load();

this._updateDefaultGw();
Expand Down