-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💻 show some roles of variables (constant, input constant, walker, container) #5500
Conversation
for more information, see https://pre-commit.ci
…into roles-of-variables
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
When testing the code with the additions in this PR, everything seems to work in level 1 to 5, but from level 6 on, random things seem not to work, like calculations in level 6 and the repeat command in level 7. |
Issue in former comment is solved! thanks @jpelay :) |
I fixed the parsing problem! But now it's not showing output when in some programs, for example this one of level 12:
There's a response and the program is shown as executed, perhaps it has to do with the fact that the variables has a type of unknown? |
The type unknown should not work any differently than the other types, it's just a string in a dictionary... I still get issues trying to test this code, ModuleNotFoundError: iso639 (see app.py line 22) |
I don't get that error in alpha, but it is normal that there is no output in that program :P |
HAHA you're right! oops |
Do the pip thing again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @juliabolt and thanks for the help @jpelay!!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Adds roles in the variable list, works for four roles now, constant, input constant, container and walker.
How to test
Follow these steps to verify this PR works as intended:
Checklist
Done? Check if you have it all in place using this list: (mark with x if done)
If you're unsure about any of these, don't hesitate to ask. We're here to help!