Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 6103 allow existing users to subscribe to the newsletter #6159

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

AnneliesVlaar
Copy link
Collaborator

@AnneliesVlaar AnneliesVlaar commented Feb 3, 2025

This PR adds "Newsletter" and "Danger zone" sections to the the profile page.

Before approving:

  • Revise the client-facing messages
  • Translate the client-facing messages to Dutch

Fixes #6103

How to test

  • Log in as a student and go to the profile page. Note that there is no Newsletter section. The Delete profile button is now under its own Danger zone section.
  • Create a new teacher account without subscribing to the newsletter at signup.
    • Go to the profile page and check that the Newsletter section is expanded by default. It should offer you to subscribe. Do not subscribe yet.
    • Log in as another teacher and invite the new teacher account you created as a student to a class (via username). Go back to the profile of the new teacher and check that the Invitations section of the profile is expanded by default but not the Newsletter. Once you accept/reject the invitation, the Newsletter section should get expanded by default.
    • Change line 69 in file newsletter.py to return True, so that you can simulate a successful subscription and restart the application. Click subscribe to the button, the UI should update without reloading the page.
    • Change line 2275 in the app.py file to subscription_status="subscribed" to simulate that there is a successful subscription. If you reload the profile page now, the Newsletter section should be disabled by default. When you open it, you should see a message confirming that you are subscribed.
    • Change the 2275 in the app.py file to subscription_status="unsubscribed". If you reload the profile page now, the Newsletter section should be expanded by default. It should ask you for feedback and let you resubscribe via the Mailchimp form.

@AnneliesVlaar AnneliesVlaar linked an issue Feb 3, 2025 that may be closed by this pull request
@boryanagoncharenko
Copy link
Collaborator

I have the following proposal. Let's add a new section in the profile page which is only about the newsletter. It should be very short and perhaps we could even choose to make it expanded by default (if there are not any other sections that need to be expanded by default such as invitations). Also, since we are on this page, let's take the delete button out of the form since it is confusing.

So, if a user has never subscribed they will see this:
Screenshot 2025-02-10 at 14 50 05

If they have subscribed and then unsubscribed, they will see this:
Screenshot 2025-02-10 at 14 48 19

And this is how the delete profile section will look like:
Screenshot 2025-02-10 at 14 50 16

What do you think?

@AnneliesVlaar
Copy link
Collaborator Author

Good idea to add a delete profile section

@AnneliesVlaar
Copy link
Collaborator Author

If a user subscribed to the newsletter and then via the link in the newsletter unsubscribed, do we know who is subscribed and unsubscribed?

@boryanagoncharenko
Copy link
Collaborator

If a user subscribed to the newsletter and then via the link in the newsletter unsubscribed, do we know who is subscribed and unsubscribed?

Yes, we do:

  • if the user has never subscribed, they are not in the Mailchimp audience
  • if the user has subscribed, we see that their status is "subscribed"
  • if the user has unsubscribed, their status is "unsubscribed"

Btw I did not cover how this section will look for the people who are already subscribed. I guess the section should not be there at all?

@AnneliesVlaar
Copy link
Collaborator Author

Ah that's great. For people who already subscribed I would suggest to have something similar to the unsubscribed:

You're subscribed to our newsletter
Run to your mailbox to see if the new issue already has been delivered!

(Or something like that)

@boryanagoncharenko boryanagoncharenko force-pushed the 6103-allow-existing-users-to-subscribe-to-the-newsletter branch from 385b1ac to 7b2b232 Compare February 16, 2025 15:08
@boryanagoncharenko boryanagoncharenko marked this pull request as ready for review February 23, 2025 13:32
@boryanagoncharenko
Copy link
Collaborator

@AnneliesVlaar would you be able to:

  • check this PR for usability
  • see whether you agree with the written text, maybe some of the messages are too wordy?
  • translate the new messages to Dutch

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

💻 Allow existing users to subscribe to the newsletter
2 participants