-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💻 6103 allow existing users to subscribe to the newsletter #6159
base: main
Are you sure you want to change the base?
💻 6103 allow existing users to subscribe to the newsletter #6159
Conversation
This reverts commit ee57b9d.
Good idea to add a delete profile section |
If a user subscribed to the newsletter and then via the link in the newsletter unsubscribed, do we know who is subscribed and unsubscribed? |
Yes, we do:
Btw I did not cover how this section will look for the people who are already subscribed. I guess the section should not be there at all? |
Ah that's great. For people who already subscribed I would suggest to have something similar to the unsubscribed: You're subscribed to our newsletter (Or something like that) |
385b1ac
to
7b2b232
Compare
…ing-users-to-subscribe-to-the-newsletter
…r' of github.com:Felienne/hedy into 6103-allow-existing-users-to-subscribe-to-the-newsletter
…ing-users-to-subscribe-to-the-newsletter
@AnneliesVlaar would you be able to:
Thanks! |
This PR adds "Newsletter" and "Danger zone" sections to the the profile page.
Before approving:
Fixes #6103
How to test
return True
, so that you can simulate a successful subscription and restart the application. Click subscribe to the button, the UI should update without reloading the page.subscription_status="subscribed"
to simulate that there is a successful subscription. If you reload the profile page now, the Newsletter section should be disabled by default. When you open it, you should see a message confirming that you are subscribed.subscription_status="unsubscribed"
. If you reload the profile page now, the Newsletter section should be expanded by default. It should ask you for feedback and let you resubscribe via the Mailchimp form.