HIP-147 #1037
Open
HIP-147 #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbalser
force-pushed
the
bbalser/hip-147
branch
from
abe06b3 to
5349080
Compare
kurotych
reviewed
Sep 9, 2025
mobile_verifier/src/reward_shares.rs
Outdated
| @@ -544,20 +541,18 @@ impl CoverageShares { | |||
| pub struct DataTransferAndPocAllocatedRewardBuckets { | |||
| pub data_transfer: Decimal, | |||
| pub poc: Decimal, | |||
There was a problem hiding this comment.
I think we can (and should) encapsulate this field by removing pub keyword. Since we have total_poc wich acts as a geter of poc
All the previous integration tests already test this since this is how it already worked, before PoC got a minimum of 20% of the reward pool, with this change it now gets a minimum of 0% |
kurotych
approved these changes
Sep 9, 2025
michaeldjeffrey
approved these changes
Sep 9, 2025
macpie
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of https://github.com/helium/HIP/blob/main/0147-mobile-data-eats-first.md