Fix docker-shim: only inject cache flags when builder available#1587
Closed
lukemarsden wants to merge 1 commit intomainfrom
Closed
Fix docker-shim: only inject cache flags when builder available#1587lukemarsden wants to merge 1 commit intomainfrom
lukemarsden wants to merge 1 commit intomainfrom
Conversation
The docker-shim was unconditionally adding --cache-from/--cache-to flags to docker build commands, even when the shared BuildKit builder wasn't available. This caused "Cache export is not supported for the docker driver" errors when using the default docker driver. Now cache flags are only injected when: 1. The shared helix-buildkit container is running 2. The helix-shared buildx builder can be created/found Without a proper builder, builds proceed normally without cache injection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
Wrong approach - should fail fast instead of silently skipping cache. Will fix properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cache-from/--cache-toflags to docker build commandshelix-sharedbuildx builder can be set upError before fix
Changes
Modified
injectBuildCacheFlags()to only add cache flags inside theif builderAvailableblock, ensuring we never add cache flags without a builder that supports them.🤖 Generated with Claude Code